Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtract: Remove RBS file if the subtracted definition is empty #1385

Merged
merged 1 commit into from
Aug 17, 2023
Merged

subtract: Remove RBS file if the subtracted definition is empty #1385

merged 1 commit into from
Aug 17, 2023

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Jul 21, 2023

No description provided.

soutaro
soutaro approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.2 milestone Aug 14, 2023
@soutaro soutaro added this pull request to the merge queue Aug 14, 2023
@soutaro soutaro removed this pull request from the merge queue due to a manual request Aug 14, 2023
@soutaro soutaro requested a review from pocke August 14, 2023 08:13
@soutaro
Copy link
Member

soutaro commented Aug 14, 2023

@pocke r? or will be merged in a few days.

@soutaro soutaro added this pull request to the merge queue Aug 17, 2023
Merged via the queue into ruby:master with commit afc9c31 Aug 17, 2023
23 checks passed
@tk0miya tk0miya deleted the rbs_subtract_removes_definition_if_empty branch August 17, 2023 09:50
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

@pocke pocke Awaiting requested review from pocke

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @soutaro